Skip to content

STYLE: Change master branch mentions to main across files #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

STYLE: Change master branch mentions to main across files #442

merged 1 commit into from
Jul 1, 2025

Conversation

@jhlegarreta
Copy link
Member

@jhlegarreta jhlegarreta commented Jun 27, 2025

Change master branch mentions to main across files.

Cross-referencing
InsightSoftwareConsortium/ITK#4732.

@github-actions github-actions bot added area:Core Issues affecting the Core module area:Documentation Issues affecting the Documentation module area:Filtering Issues affecting the Filtering module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Style Style changes: no logic impact (indentation, comments, naming) labels Jun 27, 2025
@jhlegarreta jhlegarreta mentioned this pull request Jun 27, 2025
Closed
17 tasks
dzenanz
dzenanz approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on a glance.

@dzenanz
Copy link
Member

dzenanz commented Jun 27, 2025

I guess we need to suppress warning: 'LabelGeometryImageFilterType' is deprecated: This class contains known computational bugs. See class documentation for details. [-Wdeprecated-declarations], as seen here.

And we should address this: ITK/Modules/Filtering/ImageCompose/include/itkComposeImageFilter.hxx:135:19: error: non-constant-expression cannot be narrowed from type 'itk::ImageConstIterator<itk::Image<unsigned char, 2>>::PixelType' (aka 'unsigned char') to 'float' in initializer list [-Wc++11-narrowing]

@jhlegarreta
Copy link
Member Author

jhlegarreta commented Jun 27, 2025 •
edited
Loading

Re #442 (comment) I cannot devote time to this now, so best would be to leave them for separate PRs/open issues.

@jhlegarreta
STYLE: Change master branch mentions to main across files
97836ad 
Change `master` branch mentions to `main` across files.

Cross-referencing
InsightSoftwareConsortium/ITK#4732.
@dzenanz
Copy link
Member

dzenanz commented Jun 28, 2025

That is reasonable. Merge when ready.

thewtex
thewtex approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jhlegarreta !

@thewtex thewtex merged commit d1b828b into InsightSoftwareConsortium:master Jul 1, 2025
5 of 13 checks passed
@jhlegarreta jhlegarreta deleted the RenameMasterToMain branch July 1, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewtex thewtex thewtex approved these changes

@dzenanz dzenanz dzenanz approved these changes

Assignees

No one assigned

Labels

area:Core Issues affecting the Core module area:Documentation Issues affecting the Documentation module area:Filtering Issues affecting the Filtering module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Style Style changes: no logic impact (indentation, comments, naming)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhlegarreta @dzenanz @thewtex